Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAB-823: Currency I18N #39

Merged
merged 2 commits into from
Nov 2, 2023
Merged

CAB-823: Currency I18N #39

merged 2 commits into from
Nov 2, 2023

Conversation

samumaretiya
Copy link
Contributor

No description provided.

Api/RequestHandler.php Outdated Show resolved Hide resolved
Copy link
Contributor

@soleilcot soleilcot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment about potentially unneeded condition.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soleilcot soleilcot changed the title feat: support multi-currency separator CAB-823: Currency I18N Nov 2, 2023
@soleilcot soleilcot merged commit 0186921 into master Nov 2, 2023
3 of 4 checks passed
@soleilcot soleilcot deleted the decimal_separator_fix branch November 2, 2023 15:04
nofraud-automation-bot pushed a commit that referenced this pull request Nov 2, 2023
# [1.2.0](v1.1.0...v1.2.0) (2023-11-02)

### Features

* Add support for currency internationalization ([#39](#39)) ([0186921](0186921))
@nofraud-automation-bot
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants