-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not enable SPX when JIT is enabled #215
Comments
The SPX enabling must be discarded in this case with a notice log. This incompatibility should also be mentionned in the README. |
Maybe native API for observation xhprof doing something like this:
|
Indeed, here is the corresponding patch thread tideways/php-xhprof-extension#96 I'm however wondering how it hurts performances and if the SPX hooking abstraction should in the end choose between a zend_execute_ex or a zend_observer based backend whether JIT is enabled or not. It would also allow to keep the internal function profiling feature. |
I've observed that when SPX is enabled, even if not active (i.e. auto_start=0), with JIT enabled (opcache.jit=tracing), it makes the execution flow somewhat corrupted (in my case an error is triggered with an inconsistent stack trace).
The text was updated successfully, but these errors were encountered: