Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adopting alloy RPC types #140

Closed
Tracked by #373
Wodann opened this issue Jul 20, 2023 · 1 comment
Closed
Tracked by #373

Consider adopting alloy RPC types #140

Wodann opened this issue Jul 20, 2023 · 1 comment
Assignees

Comments

@Wodann
Copy link
Member

Wodann commented Jul 20, 2023

When RPC types become part of alloy, consider adopting those in favour of our own.

Depends On:

@Wodann Wodann added this to EDR Jul 20, 2023
@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Jul 20, 2023
@Wodann Wodann added this to the EDR v0.1.0 milestone Jul 20, 2023
@Wodann Wodann moved this from Unconfirmed to Todo in EDR Jul 20, 2023
@Wodann Wodann modified the milestones: EDR v0.1.0, EDR v0.2.0 Sep 12, 2023
@Wodann Wodann removed this from the EDR v0.2.0 milestone Nov 6, 2023
@fvictorio fvictorio changed the title Adopt alloy RPC types Consider adopting alloy RPC types May 10, 2024
@fvictorio fvictorio assigned fvictorio and Wodann and unassigned fvictorio May 10, 2024
@Wodann Wodann moved this from Todo to In Progress in EDR May 10, 2024
@Wodann
Copy link
Member Author

Wodann commented Jun 5, 2024

In our code, we have a preference for strongly typed static types to enforce correctness through the compiler. Alloy's RPC types are not always statically typed. E.g see this type. In addition, it would restrict our flexibility with types, so for now we're choosing not to use Alloy RPC types

@Wodann Wodann closed this as completed Jun 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in EDR Jun 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants