Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow forking blocks with future timestamps #588

Closed
fvictorio opened this issue Aug 8, 2024 · 0 comments · Fixed by #663
Closed

Allow forking blocks with future timestamps #588

fvictorio opened this issue Aug 8, 2024 · 0 comments · Fixed by #663
Assignees

Comments

@fvictorio
Copy link
Member

If EDR forks a block whose timestamp is in "the future", then it panics with an error like this:

thread 'tokio-runtime-worker' panicked at /build/crates/edr_provider/src/data.rs:2564:18:
current time must be after fork block: SystemTimeError(3340.313588137s)

The easiest way to reproduce this manually is to just set the system clock back one hour and then fork mainnet.

I don't see any good reason to disallow this and, as far as I can tell, pre-EDR Hardhat didn't have this behavior.

See zemse/hardhat-tracer#74 (comment) for more context.

@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Aug 8, 2024
@fvictorio fvictorio moved this from Unconfirmed to Todo in EDR Aug 8, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in EDR Sep 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants