Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: solidity survey notification #312

Merged
merged 1 commit into from
Dec 15, 2022
Merged

feature: solidity survey notification #312

merged 1 commit into from
Dec 15, 2022

Conversation

antico5
Copy link
Collaborator

@antico5 antico5 commented Dec 14, 2022

No description provided.

@antico5 antico5 requested a review from kanej December 14, 2022 17:03
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (development@80743ad). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head efd3c3e differs from pull request most recent head 7b47bde. Consider uploading reports for the commit 7b47bde to get more accurate results

@@              Coverage Diff               @@
##             development     #312   +/-   ##
==============================================
  Coverage               ?   57.54%           
==============================================
  Files                  ?      174           
  Lines                  ?     4329           
  Branches               ?      706           
==============================================
  Hits                   ?     2491           
  Misses                 ?     1605           
  Partials               ?      233

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kanej
kanej approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally tweaking things and I couldn't break this.

Nicely done.

client/src/popups/showSoliditySurveyPopup.ts
context.globalState.get<boolean>("answered2022Survey") ?? false;
const lastShown = context.globalState.get<number>("survey2022LastShown") ?? 0;

if (alreadyAnswered || pastLimitDate() || shownRecently(lastShown)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful.

@antico5 antico5 merged commit 7ac3e09 into development Dec 15, 2022
@antico5 antico5 deleted the solidity-survey branch December 15, 2022 12:08
@antico5 antico5 mentioned this pull request Dec 15, 2022
Merged
antico5 added a commit that referenced this pull request Dec 15, 2022
@antico5
feature: solidity survey notification (#312)
a4fbc63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanej kanej kanej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antico5 @codecov-commenter @kanej