Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Error loading HRE from telemetry #340

Closed
kanej opened this issue Jan 3, 2023 · 3 comments · Fixed by #363
Closed

Suppress Error loading HRE from telemetry #340

kanej opened this issue Jan 3, 2023 · 3 comments · Fixed by #363
Assignees
Labels
status:ready This issue is ready to be worked on type:chore

Comments

@kanej
Copy link
Member

kanej commented Jan 3, 2023

We handle and display loading errors in the hardhat config, but send the exception on to sentry our telemetry and exception reporting system. We should suppress it from going to sentry, so our telemetry is not full of variants of:

Error loading HRE: Error: Cannot find module '@nomicfoundation/hardhat-toolbox'

@kanej kanej added type:chore status:ready This issue is ready to be worked on priority:high labels Jan 3, 2023
@sentry-io
Copy link

sentry-io bot commented Jan 3, 2023

Sentry issue: VSCODE-EXTENSION-RTA

@kanej kanej moved this to Todo in hardhat-vscode Jan 4, 2023
@antico5
Copy link
Collaborator

antico5 commented Jan 4, 2023

Can we set up filter rules on sentry or it's better to have it on the code?

@kanej
Copy link
Member Author

kanej commented Jan 4, 2023

Can we set up filter rules on sentry or it's better to have it on the code?

We can setup up filter rules on sentry, but it goes towards our error quota.

There maybe ways of doing it within the sentry client though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on type:chore
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants