Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal file keeping on file move event #417

Closed
kanej opened this issue Mar 7, 2023 · 0 comments · Fixed by #421
Closed

Update internal file keeping on file move event #417

kanej opened this issue Mar 7, 2023 · 0 comments · Fixed by #421
Assignees
Labels
status:ready This issue is ready to be worked on

Comments

@kanej
Copy link
Member

kanej commented Mar 7, 2023

The language server's internal state maintains an index of each solidity file and the project it is related to. We need to update the metadata on a file rename event occurring in the project.

See the rename event in the specification: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_didRename

Consideration should be given to dealing with existing diagnostics. The diagnostics should migrate with the rename.

Similarly we should update the metadata and diagnostics on file delete.

Part of #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Status: Done
2 participants