Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-defined value types not highlighted #420

Closed
PaulRBerg opened this issue Mar 7, 2023 · 1 comment · Fixed by #428
Closed

User-defined value types not highlighted #420

PaulRBerg opened this issue Mar 7, 2023 · 1 comment · Fixed by #428
Assignees
@antico5
Labels
status:ready This issue is ready to be worked on

Comments

@PaulRBerg
Copy link

User-defined value types have been added in v0.8.8.

hardhat-vscode doesn't highlight the types:

Screenshot 2023-03-07 at 6 19 30 PM
@PaulRBerg
Copy link
Author

This is how they should be highlighted (vscode-solidity does it like this):

VSCode Solidity UDVTs

@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels Mar 9, 2023
@kanej kanej moved this to Todo in hardhat-vscode Mar 9, 2023
@antico5 antico5 moved this from Todo to In Progress in hardhat-vscode Mar 10, 2023
@antico5 antico5 mentioned this issue Mar 13, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in hardhat-vscode Mar 14, 2023
@antico5 antico5 mentioned this issue Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antico5 antico5

Labels
status:ready This issue is ready to be worked on
Projects
hardhat-vscode
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: highlight user-defined value types NomicFoundation/hardhat-vscode
3 participants
@kanej @antico5 @PaulRBerg