Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto insert ';' at least on import #104

Closed
kanej opened this issue Mar 9, 2022 · 0 comments · Fixed by #257
Closed

Auto insert ';' at least on import #104

kanej opened this issue Mar 9, 2022 · 0 comments · Fixed by #257
Labels
type:feature New feature or request

Comments

@kanej
Copy link
Member

kanej commented Mar 9, 2022

When completing an import: import "./X", we should auto append the ; to the end of the line. Our parsing is disrupted by the lack of a ;.
@kanej kanej added the type:feature New feature or request label Mar 9, 2022
antico5 added a commit that referenced this issue Sep 9, 2022
@antico5
feat: auto insert semicolon on import completion (#104)
19031f3
@antico5 antico5 mentioned this issue Sep 9, 2022
Merged
antico5 added a commit that referenced this issue Sep 9, 2022
@antico5
feat: auto insert semicolon on import completion (#104)
f07fa2e
antico5 added a commit that referenced this issue Sep 9, 2022
@antico5
feat: auto insert semicolon on import completion (#104)
119add3
antico5 added a commit that referenced this issue Sep 9, 2022
@antico5
feat: auto insert semicolon on import completion (#104)
72cdde1
antico5 added a commit that referenced this issue Sep 9, 2022
@antico5
feat: auto insert semicolon on import completion (#104)
0c15efc
antico5 added a commit that referenced this issue Sep 12, 2022
@antico5
feat: auto insert semicolon on import completion (#104)
ddb9ebe
antico5 added a commit that referenced this issue Sep 14, 2022
@antico5
feat: auto insert semicolon on import completion (#104)
40e46eb
antico5 added a commit that referenced this issue Sep 14, 2022
@antico5
feat: auto insert semicolon on import completion (#104)
f8d9498
antico5 added a commit that referenced this issue Sep 14, 2022
@antico5
feat: auto insert semicolon on import completion (#104)
e24e75d
@antico5 antico5 changed the title Audo insert ';' at least on import Auto insert ';' at least on import Sep 14, 2022
antico5 added a commit that referenced this issue Sep 20, 2022
@antico5
feat: auto insert semicolon on import completion (#104)
ae62417
@antico5 antico5 mentioned this issue Sep 20, 2022
Merged
antico5 added a commit that referenced this issue Sep 21, 2022
@antico5
feat: auto insert semicolon on import completion (#104)
4f0b528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: auto insert semicolon on import completion NomicFoundation/hardhat-vscode
1 participant
@kanej