Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardhat-network-helpers: TODOs as soon as V3 node is ready #5757

Closed
5 of 6 tasks
ChristopherDedominici opened this issue Sep 17, 2024 · 0 comments · Fixed by #5882
Closed
5 of 6 tasks

Hardhat-network-helpers: TODOs as soon as V3 node is ready #5757

ChristopherDedominici opened this issue Sep 17, 2024 · 0 comments · Fixed by #5882
Assignees
Labels
v-next A Hardhat v3 development task
Milestone

Comments

@ChristopherDedominici
Copy link
Contributor

ChristopherDedominici commented Sep 17, 2024

Currently the tests are only available in manual mode on the local machine because the Hardhat node for V3 is not available yet.
As soon as the Hardhat V3 node is ready, this can be addressed.

TODOs for the hardhat-network-helpers:

  • delete the ./run-tests.ts file
  • delete the pnpm test:tmp command
  • update the initializeNetwork helper function at the path ./test-tmp/helpers/helpers.ts
  • move the tests from the test-tmp folder to the test folder and delete the test-tmp folder
  • update the tests that are using the allow-blocks-same-timestamp property

TODOs for the example project:

  • Remove the comment in the scrip ./scripts/network-helpers.ts that explains how to run with a V2 node

All the checked tasks are addressed here.

The task regarding allow-blocks-same-timestamp is missing because the property is not implemented yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v-next A Hardhat v3 development task
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants