[Typechain] generate types only for contracts and not test files #6400
Conversation
🦋 Changeset detectedLatest commit: 739f6b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -645,6 +638,13 @@ export class SolidityBuildSystemImplementation implements SolidityBuildSystem { | |||
| duplicatedContractNamesDeclarationFilePath, | |||
| getDuplicatedContractNamesDeclarationFile(duplicatedNames), | |||
| ); | |||
|
|
|||
| await this.#hooks.runHandlerChain( | |||
There was a problem hiding this comment.
Pato mentioned that probably this is the best place to add a hook that can emit the artifacts paths.
His message:
I think that we should change the moment when we generate the typechain types. Its now on build, but i believe it should be in cleanArtifacts. That already generates some typescript types for the artifacts. Especially when there are clashes between names. This would mean removing the hook, creating a new one after cleanupArtifacts, and using that one instead.
There was a problem hiding this comment.
This would mean we generate types only when the entire project is compiled - see
- which, as far as I understand, is not necessarily what we want.To be fair, I also find hooking types generation to the cleanup step a little confusing. It is not obvious to know what the type generation has to do with cleanup without deeply understanding the internals. I think there might be some potential for the refactor in the cleanup function, but that's definitely out of the scope of this PR.
However, as far as when the type generation should get triggered, maybe it should be when the artifacts are emitted after all. But maybe we could add some option to the build and consequently emitArtifacts to control whether artifact declaration files -
| @@ -99,19 +98,20 @@ declare module "../../../types/hooks.js" { | |||
|
|
|||
| export interface SolidityHooks { | |||
| /** | |||
| * Provide a handler for this hook to retrieve all artifacts created by a compilation job. | |||
There was a problem hiding this comment.
The old hook can be removed in favor of the new one. See previous comment for more details
| @@ -0,0 +1,6 @@ | |||
| --- | |||
There was a problem hiding this comment.
I need a double check on this changeset, is this format acceptable for the v-next?
Parent issue link