Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ordering of parsing statements variants #1019

Closed
OmarTawfik opened this issue Jun 21, 2024 · 0 comments · Fixed by #1074
Closed

ordering of parsing statements variants #1019

OmarTawfik opened this issue Jun 21, 2024 · 0 comments · Fixed by #1074
Assignees

Comments

@OmarTawfik
Copy link
Contributor

OmarTawfik commented Jun 21, 2024

We should look into this once #808 is ready:

I see ExpressionStatement and VariableDeclarationStatement were moved to the top. Is it just for organization, or does it impact parsing?

I'm asking because almost all other variants start with a unique token, so it should be faster to parse/validate them, instead of trying to parse a full expression, then backtracking when it fails.

Originally posted by @OmarTawfik in #653 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant