Skip to content

Commit 1ef2022

Browse files
Fixed failures and added javadocs
1 parent e5ff023 commit 1ef2022

File tree

3 files changed

+23
-6
lines changed

3 files changed

+23
-6
lines changed

java/vector/src/main/codegen/templates/NullableValueVectors.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ public int getBufferSizeFor(final int valueCount) {
219219
}
220220

221221
public ArrowBuf getBuffer() {
222-
return values.getBuffer();
222+
return values.getDataBuffer();
223223
}
224224

225225
@Override

java/vector/src/main/java/org/apache/arrow/vector/ValueVector.java

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,24 @@ interface Mutator {
235235
void generateTestData(int values);
236236
}
237237

238-
public ArrowBuf getDataBuffer();
238+
/**
239+
* Gets the underlying buffer associated with validity vector
240+
*
241+
* @return buffer
242+
*/
239243
public ArrowBuf getValidityBuffer();
244+
245+
/**
246+
* Gets the underlying buffer associated with data vector
247+
*
248+
* @return buffer
249+
*/
250+
public ArrowBuf getDataBuffer();
251+
252+
/**
253+
* Gets the underlying buffer associated with offset vector
254+
*
255+
* @return buffer
256+
*/
240257
public ArrowBuf getOffsetBuffer();
241258
}

java/vector/src/main/java/org/apache/arrow/vector/complex/FixedSizeListVector.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -309,17 +309,17 @@ public long getOffsetBufferAddress() {
309309
}
310310

311311
@Override
312-
public long getValidityBufferAddress() {
313-
return (bits.getDataBuffer().memoryAddress());
312+
public ArrowBuf getValidityBuffer() {
313+
return (bits.getDataBuffer());
314314
}
315315

316316
@Override
317-
public long getDataBufferAddress() {
317+
public ArrowBuf getDataBuffer() {
318318
throw new UnsupportedOperationException();
319319
}
320320

321321
@Override
322-
public long getOffsetBufferAddress() {
322+
public ArrowBuf getOffsetBuffer() {
323323
throw new UnsupportedOperationException();
324324
}
325325

0 commit comments

Comments
 (0)