Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLOM does not compile when threading is turned on #373

Closed
mvertens opened this issue Aug 12, 2024 · 1 comment · Fixed by #374 or #377
Closed

BLOM does not compile when threading is turned on #373

mvertens opened this issue Aug 12, 2024 · 1 comment · Fixed by #374 or #377

Comments

@mvertens
Copy link
Contributor

In the ERP system test - threading is turned on in the compilation even if the number of threads is 1. In this case, BLOM was not able to compile successfully. The culprit was mod_nctools.F90. This was with BLOM%ECO. Is anyone running BLOM with the number of threads > 1. Will this work?

@matsbn
Copy link
Contributor

matsbn commented Aug 12, 2024

BLOM without iHAMOCC used to work well with threads > 1. The recent code with hybrid functionality has a lot of lacking OMP statements for loop blocks. It might work, although not tested, but certainly not efficient. I think there was an effort to fix the OMP statements in iHAMOCC, but not sure about the status. On the machines we have had available, we never experienced a useful speedup with hybrid MPI/OpenMP parallelization as far as I can remember. Still, I think it is worthwhile to have the ability for hybrid parallelization.

@mvertens mvertens linked a pull request Aug 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants