Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose SecureDFUExtendedErrorCode — unable to get relevant error from client code #262

Closed
al-zonke opened this issue Jan 24, 2019 · 3 comments
Closed

Expose SecureDFUExtendedErrorCode — unable to get relevant error from client code #262

al-zonke opened this issue Jan 24, 2019 · 3 comments
Assignees
@philips77
Labels
enhancement
Milestone
4.3.0

Comments

@al-zonke
Copy link

From client code I want to distinguish different types of error.
Especially SecureDFUExtendedErrorCode, that are internal and exposed just by their description value. In some cases it's reasonable to retry OTA with different parameters depending from particular error reason
@philips77
Copy link
Member

Indeed, it could be useful. Such change would break backwards compatibility, as .extendedError would not be thrown anymore.
Could you do necessary PR to develop branch? We don't have resources right now to solve this issue. Or you can retry OTA based on the description...

@philips77 philips77 self-assigned this Jan 29, 2019
@philips77 philips77 mentioned this issue Feb 25, 2019
Merged
@philips77
Copy link
Member

Hi, I've just made a PR with requested change.
Also, keep in mind, that with #266 the library will now (starting from version 4.3.0) automatically try to send App when a remote error was received from SD+BL init packet validation (in case a ZIP file has SD(+BL)+App). Don't know if it applies to you.

@philips77
Copy link
Member

This will be released in 4.3.0.

@philips77 philips77 added this to the 4.3.0 milestone Feb 26, 2019
@philips77 philips77 mentioned this issue Mar 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philips77 philips77

Labels
enhancement
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
2 participants
@al-zonke @philips77