Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev tools integration tests does not stop on error #519

Open
lentzi90 opened this issue Apr 21, 2022 · 0 comments
Open

Dev tools integration tests does not stop on error #519

lentzi90 opened this issue Apr 21, 2022 · 0 comments

Comments

@lentzi90
Copy link
Member

As seen here the test is not aborted when the upload to artifactory fails. Instead it continues all the way until trying to download that image from artifactory. Of course, this fails and the test is aborted.

We should make sure the test is aborted early if the upload fails.

Here is the error on upload:

++ curl -u****:**** https://artifactory.nordix.org/artifactory/metal3/images/temp/centos_TEMP_IMG_ompx.qcow2 -T /tmp/node_image/centos_TEMP_IMG_ompx.qcow2
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  1 2567M    0     0    1 39.5M      0   104M  0:00:24 --:--:--  0:00:24  104M
  7 2567M    0     0    7  180M      0   130M  0:00:19  0:00:01  0:00:18  130M
[removed for brevity...]
 94 2567M    0     0   94 2426M      0   132M  0:00:19  0:00:18  0:00:01  136M
 99 2567M    0     0   99 2554M      0   131M  0:00:19  0:00:19 --:--:--  133M
100 2567M  100   157  100 2567M      7   130M  0:00:22  0:00:19  0:00:03  131M
<html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx/1.20.1</center>
</body>
</html>

And here is the error when trying to download the image later:

+ wget --no-verbose --no-check-certificate https://artifactory.nordix.org/artifactory/metal3/images/temp//centos_TEMP_IMG_ompx.qcow2
https://artifactory.nordix.org/artifactory/metal3/images/temp//centos_TEMP_IMG_ompx.qcow2:
2022-04-20 14:50:14 ERROR 404: Not Found.
make: *** [Makefile:4: install_requirements] Error 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lentzi90