You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Server class is registering response code metrics in its constructor, via a call to a helper addResponseCodeMeters.
This is a weird place for this to happen, and it's totally different from where the other per-request metrics are created and tracked (in the CompiledRoutes constructor).
We should pick a place this happens, and handle it in an organized way.
Our rate limits, firewall, and IP white/black lists also track metrics, but do so in a localized way which seems fine.
The text was updated successfully, but these errors were encountered:
It would also be nice if the response code meters worked for ALL response codes, not just those that were pre-registered. Right now, any responses outside of the known codes are silently dropped from counting.
The
Server
class is registering response code metrics in its constructor, via a call to a helperaddResponseCodeMeters
.This is a weird place for this to happen, and it's totally different from where the other per-request metrics are created and tracked (in the
CompiledRoutes
constructor).We should pick a place this happens, and handle it in an organized way.
Our rate limits, firewall, and IP white/black lists also track metrics, but do so in a localized way which seems fine.
The text was updated successfully, but these errors were encountered: