Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server should not be registering response code metrics #152

Open
jkinkead opened this issue Feb 23, 2018 · 1 comment
Open

Server should not be registering response code metrics #152

jkinkead opened this issue Feb 23, 2018 · 1 comment

Comments

@jkinkead
Copy link
Contributor

The Server class is registering response code metrics in its constructor, via a call to a helper addResponseCodeMeters.

This is a weird place for this to happen, and it's totally different from where the other per-request metrics are created and tracked (in the CompiledRoutes constructor).

We should pick a place this happens, and handle it in an organized way.

Our rate limits, firewall, and IP white/black lists also track metrics, but do so in a localized way which seems fine.

@jkinkead
Copy link
Contributor Author

It would also be nice if the response code meters worked for ALL response codes, not just those that were pre-registered. Right now, any responses outside of the known codes are silently dropped from counting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant