Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Fix inner data type handling in interval scorers #48

Closed
Tveten opened this issue Dec 4, 2024 · 0 comments · Fixed by #50
Closed

[MNT] Fix inner data type handling in interval scorers #48

Tveten opened this issue Dec 4, 2024 · 0 comments · Fixed by #50
Assignees
@Tveten

Comments

@Tveten
Copy link
Collaborator

Tveten commented Dec 4, 2024

  • Handle inner data type handling in the base class.

    • Avoids having to store both the input as self._X and then another version used internally in _predict again.

  • Store precomputed quantities not as sums_ but _sums. They are not really fit model parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tveten Tveten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix inner data type in interval scorer and unify cost names NorskRegnesentral/skchange
1 participant
@Tveten