Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change Requests] - Paginate getAllChangeRequests #3146

Open
jr1221 opened this issue Jan 21, 2025 · 0 comments
Open

[Change Requests] - Paginate getAllChangeRequests #3146

jr1221 opened this issue Jan 21, 2025 · 0 comments
Labels
difficult technical improvement Improvements a user might not notice

Comments

@jr1221
Copy link

jr1221 commented Jan 21, 2025

Description

Right now there are alot of change requests. So a web request to get them pulls alot of data and takes on the order of seconds no matter the internet connection.

Acceptance Criteria

  • It only fetches change requests it needs to show
  • Filtering still works

Proposed Solution

  • Paginate the getAllChangeRequests API such that the client can pass in the number of change rquests it wants to fetch.
  • Somehow dont break filtering? This might mean filtering has to be server-side which leads to more requests for sure. Maybe upon loading the projects page the first [rowsPerPage] change requests with the given filter can be called, then all other change requests can be fetched asynchronously in the background.

Mocks

No response

@jr1221 jr1221 added difficult technical improvement Improvements a user might not notice labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficult technical improvement Improvements a user might not notice
Projects
None yet
Development

No branches or pull requests

1 participant