Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAD/Project File Reviews] - Create shared type, query args, and transformer for parts #3166

Open
3 tasks
Tracked by #2667
chpy04 opened this issue Jan 23, 2025 · 0 comments
Open
3 tasks
Tracked by #2667
Assignees

Comments

@chpy04
Copy link
Contributor

chpy04 commented Jan 23, 2025

Description

We need to have two different kinds of parts that will be retrieved by endpoints. The first type is a partPreview, which has relevant relations excluding submissions and reviews, which will be used to display parts on the parts tab. The second type is a part, which includes submissions and reviews, and will be used for all information on a parts page. We want query args, a shared type, and a transformer for the part type.

Acceptance Criteria

  • There is a parts-review.query-args.ts file with query args for part-preview, which returns the model with all relevant information within a part, including submissions and reviews
  • There is a transformer in parts-review.transformer.ts that converts a prisma model type into the part shared type
  • there is a shared type in parts-review.types.ts in the shared folder with corresponding interfaces and relevant data

Proposed Solution

Will be very similar to the partPreview additions, but will utilize query args, transformers, and shared types for submissions and reviews.

Mocks

No response

@chpy04 chpy04 mentioned this issue Jan 23, 2025
11 tasks
@justalittlemushroom justalittlemushroom self-assigned this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants