Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] - Take in interrupt line as a parameter in the overlay #97

Open
jr1221 opened this issue Feb 17, 2024 · 1 comment
Open

[Cleanup] - Take in interrupt line as a parameter in the overlay #97

jr1221 opened this issue Feb 17, 2024 · 1 comment
Labels
feature New feature or request good beginner NER problem Good for NER newcomers optimization This is making a feature work better

Comments

@jr1221
Copy link
Contributor

jr1221 commented Feb 17, 2024

Description

Right now, the newracom overlay file in the board/tpu directory has a hardcoded interrupt.

Acceptance Criteria

  • can change interrupt without recompiling overlay

Proposed Solution

It should instead be a parameter like mcp2515-can0-spi4 so the config.txt can dynamically change the interupt pin. The default on config.txt should be that of TPU v1, but the other interrupt for stock ALFA hats should be noted in a comment.

@jr1221 jr1221 added feature New feature or request good beginner NER problem Good for NER newcomers optimization This is making a feature work better labels Feb 17, 2024
@jr1221 jr1221 changed the title [HaLow] - Take in interrupt line as a parameter in the overlay [Cleanup] - Take in interrupt line as a parameter in the overlay Feb 17, 2024
@jr1221
Copy link
Contributor Author

jr1221 commented Feb 17, 2024

Also remove the one in the package directory and switch AP over to the other one with the correct interrupt ofc. Put the dts in a common folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good beginner NER problem Good for NER newcomers optimization This is making a feature work better
Projects
None yet
Development

No branches or pull requests

1 participant