impl

Issue imixs#191
NourEldin-Ali · Feb 20, 2023 · cebcd30 · cebcd30
1 parent f65e64e
commit cebcd30
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/...pmn.glsp-server/src/main/java/org/openbpmn/extension/DefaultBPMNDefinitionsExtension.java b/...pmn.glsp-server/src/main/java/org/openbpmn/extension/DefaultBPMNDefinitionsExtension.java
@@ -208,6 +208,7 @@ private void addSignals(final BPMNModel model, final DataBuilder dataBuilder, fi
                 // the id is used to find the signal in the bpmn model later
                 dataBuilder.addData("id", bpmnSignal.getId());
             }
+            dataBuilder.closeArrayBuilder();
         }
 
     }

diff --git a/...bpmn.glsp-server/src/main/java/org/openbpmn/extension/SignalEventDefinitionExtension.java b/...bpmn.glsp-server/src/main/java/org/openbpmn/extension/SignalEventDefinitionExtension.java
@@ -137,6 +137,7 @@ public void buildPropertiesForm(final BPMNElement bpmnElement, final DataBuilder
                 }
 
             }
+
         }
 
     }

diff --git a/open-bpmn.glsp-server/src/main/java/org/openbpmn/glsp/jsonforms/DataBuilder.java b/open-bpmn.glsp-server/src/main/java/org/openbpmn/glsp/jsonforms/DataBuilder.java
@@ -112,14 +112,15 @@ public DataBuilder addObject() {
      * Helper Method to close an open array builder. The method adds an existing
      * arrayObjectBuilder.
      */
-    private void closeArrayBuilder() {
+    public void closeArrayBuilder() {
         if (arrayObjectBuilder != null) {
             if (arrayObjectBuilder != null) {
                 arrayBuilder.add(arrayObjectBuilder.build());
                 arrayObjectBuilder = null;
 
             }
-            rootBuilder.add(arrayName, arrayBuilder);
+            rootBuilder.add(arrayName, arrayBuilder.build());
+            arrayBuilder = null;
         }
     }
 

diff --git a/open-bpmn.glsp-server/src/main/java/org/openbpmn/glsp/model/BPMNGModelFactory.java b/open-bpmn.glsp-server/src/main/java/org/openbpmn/glsp/model/BPMNGModelFactory.java
@@ -278,6 +278,7 @@ void applyBPMNExtensions(final GModelElement elementNode, final BPMNElement bpmn
                 if (extension.handlesBPMNElement(bpmnElement)) {
                     // add JSONForms Schemata
                     extension.buildPropertiesForm(bpmnElement, dataBuilder, schemaBuilder, uiSchemaBuilder);
+                    dataBuilder.closeArrayBuilder();
 
                     // if the extension is not a Default Extension then we add the extension css
                     // class
-Original file line number
+Diff line change
@@ Expand Up @@
                     // the id is used to find the signal in the bpmn model later
                     dataBuilder.addData("id", bpmnSignal.getId());
                 }
+                dataBuilder.closeArrayBuilder();
             }
         }
@@ Expand Down @@