Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More clean up in shared parser code #210

Open
github-actions bot opened this issue Jun 16, 2024 · 0 comments
Open

More clean up in shared parser code #210

github-actions bot opened this issue Jun 16, 2024 · 0 comments

Comments

@github-actions
Copy link

Probably can avoid this wrapping/unwrapping by using one type or something?

Line: 177

shift_definition_data: &ShiftDefinitionData,
) -> (ShiftOperand, ShiftType, u8) {
match shift_definition_data {
// TODO: More clean up in shared parser code
// category=Refactoring
// Probably can avoid this wrapping/unwrapping by using one type or something?
crate::parsers::instruction::ShiftDefinitionData::Immediate(shift_type, shift_count) => {
(ShiftOperand::Immediate, *shift_type, *shift_count)
}
crate::parsers::instruction::ShiftDefinitionData::Register(shift_type, shift_count) => (
ShiftOperand::Register,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants