Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make github check hashes of steamworks library binaries #197

Open
ymo-4 opened this issue Aug 4, 2024 · 1 comment
Open

make github check hashes of steamworks library binaries #197

ymo-4 opened this issue Aug 4, 2024 · 1 comment

Comments

@ymo-4
Copy link
Contributor

ymo-4 commented Aug 4, 2024

Recently saw that you can just open the pull request with the steamworks binaries in it for an update. So it will be good to automatically check the hashes of those binaries or better the whole ./steamworks-sys/lib/steam/ directory in case someone wants to inject malicious code in. Since it's probably possible to download steamworks lib by a direct url without any restrictions, it should also be possible to implement something like read steamworks version from file -> get the archive from https://partner.steamgames.com/downloads/steamworks_sdk_<version here without dot>.zip -> unpack -> get the hash of both unpacked archive and current commit -> compare it!.

Hope you checked the hashes every time someone made a pull request with a steamworks update or really trust the people who made and continue to make these updates!

@Noxime
Copy link
Owner

Noxime commented Aug 5, 2024

Hi, this definitely could be automated. So far I have manually verified the sha1 hashes of PR'd updates or updated the files myself, but humans can of course make mistakes or forget. A GH Action could do it very reliably. I will see about adding it as a check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants