Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The package version dropdown in the VS PMUI package details pane doesn't show which versions are deprecated in the Browse tab, but does in the other tabs #11129

Closed
chrisraygill opened this issue Aug 4, 2021 · 3 comments

Comments

@chrisraygill
Copy link
Contributor

chrisraygill commented Aug 4, 2021

NuGet Product Used

Visual Studio Package Management UI

Product Version

Visual Studio 17.0 preview 3

Worked before?

I think so, but not sure which version. Bug exists in 16.11 preview 3.

Impact

No response

Repro Steps & Context

Repro

  1. Got to the VS PMUI Browse tab
  2. Search for WindowsAzure.Storage (all versions are deprecated)
  3. Select WindowsAzure.Storage to open the package detail pane
  4. Click on version dropdown menu
  5. Notice that none of the version numbers show "(Deprecated)" next to them

image

Expected behavior

In the Browse tab, the version dropdown menu should show which versions are deprecated. This currently works in the Installed and Updates tabs as shown:

image

This should work in both the project and solution level PMUI windows.

@aortiz-msft
Copy link
Contributor

@martinrrm - Would you please take a look at this one? Feel free to sync with @jebriede

@donnie-msft
Copy link
Contributor

I believe this bug may be because PackageItemViewModel.UpdatePackageStatus() is only called with a collection of installed packages. Browse tab should also be loading this metadata for packages not yet installed, so I'm not sure how this was designed to work. Perhaps I'm missing something...
https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Clients/NuGet.PackageManagement.UI/ViewModels/PackageItemViewModel.cs#L689
/cc @jebriede @martinrrm

@martinrrm
Copy link
Contributor

Deprecated and Vulnerabilities information is available in Browse tab in versions dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants