Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete API error when building in source-build #12988

Closed
NikolaMilosavljevic opened this issue Nov 6, 2023 · 2 comments · Fixed by NuGet/NuGet.Client#5496
Closed

Obsolete API error when building in source-build #12988

NikolaMilosavljevic opened this issue Nov 6, 2023 · 2 comments · Fixed by NuGet/NuGet.Client#5496
Labels
Partner:DotNet Type:Engineering product/infrastructure work/not a customer bug/feature/DCR
Milestone

Comments

@NikolaMilosavljevic
Copy link

When building nuget.client repo in full product source-build we see the following error:

/vmr/src/nuget-client/src/NuGet.Core/NuGet.Frameworks/FrameworkException.cs(17,88): error SYSLIB0051: 'Exception.Exception(SerializationInfo, StreamingContext)' is obsolete: 'This API supports obsolete formatter-based serialization. It should not be called or extended by application code.' (https://aka.ms/dotnet-warnings/SYSLIB0051) [/vmr/src/nuget-client/src/NuGet.Core/NuGet.Frameworks/NuGet.Frameworks.csproj::TargetFramework=net8.0]

To work around this, source-build process have been modifying Directory.Build.props during build to add a nowarn for SYSLIB0051. We are moving away from modifying sources during source-build and this needs to be fixed in the repo.

I will be creating a PR to fix this issue.

@ghost
Copy link

ghost commented Nov 7, 2023

Issue is missing Type label, remember to add a Type label

@ghost ghost added the missing-required-type The required type label is missing. label Nov 7, 2023
@ghost
Copy link

ghost commented Nov 9, 2023

Issue is missing Type label, remember to add a Type label

@kartheekp-ms kartheekp-ms added the Type:Engineering product/infrastructure work/not a customer bug/feature/DCR label Nov 10, 2023
@ghost ghost removed the missing-required-type The required type label is missing. label Nov 10, 2023
@kartheekp-ms kartheekp-ms added Partner:DotNet missing-required-type The required type label is missing. labels Nov 10, 2023
@ghost ghost removed the missing-required-type The required type label is missing. label Nov 10, 2023
@jgonz120 jgonz120 added this to the 6.9 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner:DotNet Type:Engineering product/infrastructure work/not a customer bug/feature/DCR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants