dotnet add package adds inappropriate metadata to Directory.Packages.props

[AArnott]

NuGet Product Used

dotnet.exe

Product Version

8.0.204

Worked before?

No response

Impact

It's more difficult to complete my work

Repro Steps & Context

I ran the following command line in the directory of an SDK style csproj where CPVM is turned on:

dotnet add package MessagePackAnalyzer --version 3.0.54-alpha

This added the following xml to my csproj:

    <PackageReference Include="MessagePackAnalyzer">
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>

That looks good. But it also added the following xml to my Directory.Packages.props:

    <PackageVersion Include="MessagePackAnalyzer" Version="3.0.54-alpha">
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
      <PrivateAssets>all</PrivateAssets>
    </PackageVersion>

PackageVersion items are not expected to have the metadata that the tool added, are they?

Verbose Logs

No response

[jeffkl]

@AArnott you are correct, dotnet add package should not be adding that metadata to the <PackageVersion /> item. It looks like this would only happen for packages marked as a development dependency? Does that sound right?

[AArnott]

Yes, that would explain how it hasn't been reported before.

[AArnott]

This is still broken.