Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize mechanism to distribute localized assemblies via dotnet pack #5186

Open
rohit21agrawal opened this issue May 8, 2017 · 9 comments
Labels
Functionality:Pack Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Status:Excluded from icebox cleanup Status:Inactive Icebox issues not updated for a specific long time Type:DCR Design Change Request
Milestone

Comments

@rohit21agrawal
Copy link
Contributor

No description provided.

@rohit21agrawal rohit21agrawal added this to the 4.3 - 5/8 thru 5/27 milestone May 8, 2017
@rohit21agrawal rohit21agrawal self-assigned this May 8, 2017
@kzu
Copy link

kzu commented May 12, 2017

This is already supported in NuGetizer (has mostly always been, rather?)

@rohit21agrawal
Copy link
Contributor Author

Does nugetizer add all localized assemblies to the same nupkg? Or creates nupkg per culture?

@kzu
Copy link

kzu commented May 16, 2017

Adds the satellite resources to the main package

@clairernovotny
Copy link

In Humanizer, we need to create one package per culture and a metapackage that references all cultures. Would love to use pack targets for this but am currently blocked https://github.com/Humanizr/Humanizer/tree/dev/NuSpecs

@rohit21agrawal
Copy link
Contributor Author

@onovotny pack targets already add satellite assemblies (if they are part of SatelliteDllsProjectOutputGroup) to the nupkg in the culture folder inside lib. Am i missing something that you require?

@rohit21agrawal
Copy link
Contributor Author

@onovotny or is your expectation that pack should create an individual nupkg for each culture and a metapackage that references each of them?

@clairernovotny
Copy link

Yes....we require creating a language specific nupkg per satellite resource. Not including them in the main package.

@rohit21agrawal
Copy link
Contributor Author

@onovotny can i ask why are you against putting all satellite resources in the main package?

@clairernovotny
Copy link

The expectation is that we should have that option. We are doing this because some users explicitly don't want all of the languages "polluting their output". I think it's silly, but it's what the users want. By using the satellite packages, people can choose the languages they want. Or they can use the main metapackage and get them all.

@nkolev92 nkolev92 modified the milestones: Future-0, Backlog Oct 17, 2017
@mishra14 mishra14 added the Priority:2 Issues for the current backlog. label Oct 18, 2017
@mishra14 mishra14 removed their assignment Aug 13, 2018
@ghost ghost added the Status:Inactive Icebox issues not updated for a specific long time label Sep 1, 2022
@nkolev92 nkolev92 added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Priority:2 Issues for the current backlog. labels Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Pack Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Status:Excluded from icebox cleanup Status:Inactive Icebox issues not updated for a specific long time Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

8 participants