dotnet list package does not indicate presence of a deprecated package

[anangaur]

As part of the PR NuGet/NuGet.Client#2928, it was supposed to put an indication on the presence of a deprecated package with the command dotnet list package. However it doesn't seem to work.

dotnet list package --deprecated works however.

Feature issue: #2867

[nkolev92]

Can you clarify what the indicator of the presence of a deprecated package is?

The appearance of the legend or?

[anangaur]

Thats right. It was supposed to do this:

Right now it doesn't put the legend.

[xavierdecoster]

Looks like a mismatch in expectations: marking deprecated packages as part of dotnet list package (without --outdated or --deprecated switch) wasn't part of the spec.

If dotnet list package already shows the deprecated packages, then what's the purpose of dotnet list package --deprecated? How do they differ?

[nkolev92]

Rereading now I agree with @xavierdecoster, dotnet list package itself should remain offline.

[anangaur]

The spec calls out that we needed to show the deprecation info even as part of --outdated albeit with minimal flagging. I dont think it does that today:

> dotnet list package --outdated

The following sources were used:
   https://api.nuget.org/v3/index.json

Project `My.Test.Project` has the following updates to its packages
   [netcoreapp3.0]:
   Top-level Package      Requested   Resolved   Latest
   > Newtonsoft.Json      11.0.2      11.0.2     12.0.2

But --deprecated shows the deprecated package:

> dotnet list package --deprecated

The following sources were used:
   https://api.nuget.org/v3/index.json

Project `My.Test.Project` has the following deprecated packages
   [netcoreapp3.0]:
   Top-level Package      Resolved   Reason(s)   Alternative
   > My.Sample.Lib        6.0.0      Legacy      My.Awesome.Package

[nkolev92]

Ahh, maybe that happens because My.Sample.Lib is not outdated?

[rrelyea]

Can you folks conclude?

[nkolev92]

This was something that was cleared up in the context of adding vulnerability to dotnet list package https://github.com/NuGet/Home/blob/dev/proposed/2020/PackageVulnerability/DotnetListPackageVulnerable.md