Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static Graph restore won't warn for invalid projects #9300

Closed
Tracked by #9803
nkolev92 opened this issue Mar 13, 2020 · 1 comment · Fixed by NuGet/NuGet.Client#5512
Closed
Tracked by #9803

Static Graph restore won't warn for invalid projects #9300

nkolev92 opened this issue Mar 13, 2020 · 1 comment · Fixed by NuGet/NuGet.Client#5512
Assignees
@martinrrm
Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Functionality:Restore Priority:2 Issues for the current backlog. Style:PackageReference Triage:Investigate Type:DCR Design Change Request
Milestone
6.9

Comments

@nkolev92
Copy link
Member

Have a sln with 2 projects, one restoreable, the other without the NuGet.targets.

Regular restore will warn https://github.com/NuGet/NuGet.Client/blob/b6ba5908951c172ed7df75e3074a7af409f743d7/src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets#L282-L292, while static graph restore quietly skips the project.

cc @jeffkl

We need to understand what we want the experience to be.
@nkolev92 nkolev92 added Functionality:Restore Area:RestoreStaticGraph Issues related to the Static Graph restore Style:PackageReference Triage:Investigate Category:Quality Week Issues that should be considered for quality week labels Mar 13, 2020
@jeffkl
Copy link
Contributor

jeffkl commented Mar 16, 2020

This would be easy to add so yeah we just need to brainstorm on the experience

@aortiz-msft aortiz-msft added Type:DCR Design Change Request Priority:2 Issues for the current backlog. labels Feb 2, 2022
@nkolev92 nkolev92 mentioned this issue Apr 27, 2022
Open
1 task
@jeffkl jeffkl mentioned this issue Feb 6, 2023
Open
13 tasks
@jeffkl jeffkl mentioned this issue Apr 10, 2023
Closed
@martinrrm martinrrm self-assigned this Oct 24, 2023
@martinrrm martinrrm mentioned this issue Nov 17, 2023
Merged
8 tasks
@martinrrm martinrrm removed the Category:Quality Week Issues that should be considered for quality week label Nov 20, 2023
@jeffkl jeffkl added this to the 6.9 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinrrm martinrrm

Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Functionality:Restore Priority:2 Issues for the current backlog. Style:PackageReference Triage:Investigate Type:DCR Design Change Request
Projects
None yet
Milestone
6.9
Development

Successfully merging a pull request may close this issue.

Static graph restore should warn for unsupported projects NuGet/NuGet.Client
5 participants
@nkolev92 @jeffkl @martinrrm @heng-liu @aortiz-msft