Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the order of NuGet Package Feeds in VS Options Dialog #9653

Closed
vsfeedback opened this issue Jun 5, 2020 · 4 comments
Closed

Save the order of NuGet Package Feeds in VS Options Dialog #9653

vsfeedback opened this issue Jun 5, 2020 · 4 comments
Labels
Area:Settings NuGet.Config and related issues Functionality:VisualStudioUI Priority:2 Issues for the current backlog. Type:Bug

Comments

@vsfeedback
Copy link

This issue has been moved from a ticket on Developer Community.


You can add multiple Nuget-Feed-Sources with VisualStudio which is then save to "%AppData%\NuGet\NuGet.Config".
In VisualStudio you can change the order of that sources but the order is not saved into the config. After a VS restart the order has not changed.
Workaround: Editing the file manually.


Original Comments

Visual Studio Feedback System on 6/3/2020, 01:57 AM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.


Original Solutions

(no solutions)

@dominoFire dominoFire added Functionality:VisualStudioUI Type:Bug Area:Settings NuGet.Config and related issues Priority:2 Issues for the current backlog. labels Jun 5, 2020
@dominoFire dominoFire changed the title Save the order of Nuget-Packag-Feeds Save the order of NuGet Package Feeds in VS Options Dialog Jun 5, 2020
@nkolev92
Copy link
Member

nkolev92 commented Jun 5, 2020

We've been wanting to remove the arrow keys from the options dialog.
#8315

Starting with VS 2015, there's no such thing as a preference order of sources (project.json & PackageReference are pretty adamant about it). This is even more of a problem when you can account for the fact that NuGet configs are merged, so sources could be coming from different configs.

My vote would be to close this issue and add a comment about changing the persistence order in #7973.

The problem with the current UI is that it's not obvious where the sources are defined. They could be defined in multiple configs and there's no way to express that. The UI redesign in #7973 covers that.

@donnie-msft
Copy link
Contributor

8315 - not sure that we said we wanted to remove them. Why not make them change the order?
Lots of input for that here #3676
You can change the order in a config manually.

7973 - I would call this "a bulleted list of relatively broad UI config concepts". Do we have anything solidified, any mockups?

@nkolev92
Copy link
Member

nkolev92 commented Jun 6, 2020

not sure that we said we wanted to remove them.

I discussed with Karan about a year back. Regardless, he doesn't own it anymore so that's a moot point.

Why not make them change the order?
Lots of input for that here #3676

2 reasons

Arrows as priority order

I want to call attention to the specific response the NuGet team gave in the issue you linked #3676 (comment).
The customer interpreta priority that does not exist. The only source preference that's existed is packages.config, the selected source was treated as a primary source and that's the one that'd be use to obtain the package when necessary.
That priority never manifest in the package source options dialog.

Arrows as persistence order

In this particular issue a customer wants the arrows to control the persistence order of the sources. So we have examples of 2 different customers misinterpreting the arrows.
The complexity with this particular aspect is something I described in the above issue:

This is even more of a problem when you can account for the fact that NuGet configs are merged, so sources could be coming from different configs.

What happens when you move a source lower, in a range of sources defined in a different file. Do you move the declaration from one nuget.config file to another? Is that obvious to the customer?

Wrapping it up

My conclusion from it all, the arrows add no obvious value to the topic and are ambigious.
The current UI as is, does not provide sufficient enough detail to implement such a functionality.

7973 - I would call this "a bulleted list of relatively broad UI config concepts". Do we have anything solidified, any mockups?

#7973 captures the requirements for a settings UI redesign. I've not seen any finalized mock-ups myself. That issue is not actively worked on.

Incremental progress

Given the cascading behavior of NuGet.config, the current UI is obviously lacking and in need of a refresh. #7973 is used to track the requirements.
Given the number of people that have been confused by the arrows, I think we should remove them. It's cheap to do and eliminates unnecessary confusion.

@nkolev92
Copy link
Member

Either way slice it, the feedback here is the same as #8315, closing it as dup of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Settings NuGet.Config and related issues Functionality:VisualStudioUI Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Development

No branches or pull requests

4 participants