fix incorrect as usage in ProjectFactory #6191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Community
nkolev92
previously approved these changes
Dec 18, 2024
Nigusu-Allehu
previously approved these changes
Dec 18, 2024
Nigusu-Allehu
dismissed stale reviews from nkolev92 and themself
via
c7db036
Nigusu-Allehu
previously approved these changes
Dec 18, 2024
| @@ -143,24 +143,15 @@ private void Initialize(dynamic project) | |||
| } | |||
|
|
|||
| // This happens before we obtain warning properties, so this Logger is still IConsole. | |||
| IConsole console = Logger as IConsole; | |||
| switch (LogLevel) | |||
| if (Logger is IConsole console) | |||
There was a problem hiding this comment.
A lot of tests were failing because Logger was NullLogger which resulted in an invalid cast exception. Instead of as we could use is and do a onetime check if the Logger is an IConsole type.
There was a problem hiding this comment.
Another thing we could do is
if (LogLevel != LogLevel.Debug)
{
var console = (IConsole)Logger;
console.Verbosity = LogLevel switch
{
LogLevel.Verbose => Verbosity.Detailed,
LogLevel.Information => Verbosity.Normal,
LogLevel.Minimal => Verbosity.Quiet,
_ => console.Verbosity
};
}And in our tests make sure LogLevel == LogLevel.Debug
Nigusu-Allehu
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
Description
PR Checklist