Manage packages page / user profile broken #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2013 12:43
…eference bug that would occur if you have no latest package for that packageRegistration, i.e. you unlist all versions of that package.
… the redundant LINQ query from UsersController.cs - that was probably a bad merge? And possibly fix a bug where the package download count shown in Profile was that of the package and not the package registration.
| { | ||
| mergedResults[package.PackageRegistration.Id] = package; | ||
| } | ||
| mergedResults[package.PackageRegistration.Id] = package; |
There was a problem hiding this comment.
There's gotta be a LINQier way to do this, but whatever :)
There was a problem hiding this comment.
Enumerable.Union maybe? :)
|
|
analogrelay
added a commit
that referenced
this pull request
Oct 7, 2013
…rokenForBhuva Manage packages page / user profile broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1370 - manage my packages page broken when you have a completely unlisted package
(Also fixes