Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit #1668

Merged
merged 1 commit into from
Oct 22, 2013
Merged

initial commit #1668

merged 1 commit into from
Oct 22, 2013

Conversation

johnataylor
Copy link
Member

Fixes #1669

Added dots and hover to show exact number on line graph of downloads on statistics page.

The point of this is obviously the hover text - the dot gives you something to hover over.

For the hover text, toLocaleString() did not behave consistently on all the browsers (on IE it shows .00 ) so I resorted to d3.format which is not particularly localized (as far as I know) but is consistent with the axis formatting - so this is really a more correct solution

not sure we were tracking an issue for this one yet. fix is very simple and localized anyhow.

So far I've tested on Firefox, IE, Chrome and Opera

@analogrelay
Copy link
Contributor

Is there a bug for this? If not, can you create one?

@analogrelay
Copy link
Contributor

Looks good though, once it gets attached to a bug, I say :shipit:

@johnataylor
Copy link
Member Author

issue #1669

johnataylor added a commit that referenced this pull request Oct 22, 2013
@johnataylor johnataylor merged commit a58ac80 into dev Oct 22, 2013
@analogrelay analogrelay deleted the add-dots-to-line-graph branch December 9, 2013 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants