Fix NuGet/NuGetGallery#1965 by restoring commit metadata #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -155,7 +155,7 @@ | |||
| } | |||
|
|
|||
| if(ver.BuildDateUtc != DateTime.MinValue) { | |||
| @: Built at @ver.BuildDateUtc.ToNuGetShortDateTimeString(). | |||
| @: Built at <span class="s-localtime" data-utc="@ver.BuildDateUtc.ToString("O")">@ver.BuildDateUtc.ToShortDateString()</span>. | |||
There was a problem hiding this comment.
Why not ToNuGetShortDateTimeString() anymore?
There was a problem hiding this comment.
Ah, because you're converting to local time on the client.
There was a problem hiding this comment.
Yeah, though I will restore the ToNuGetShortDateTimeString because the content of the Span is what is shown if JavaScript is disabled :). I got tired of doing math so I wanted to get the build date in to local time :P
|
|
analogrelay
added a commit
that referenced
this pull request
Mar 17, 2014
Fix #1965 by restoring commit metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1965 by restoring commit metadata. See screenshot below: