Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NuGet.org Bug]: Large package uploads through the web site fail silently #9393

Closed
agr opened this issue Feb 18, 2023 · 2 comments
Closed

[NuGet.org Bug]: Large package uploads through the web site fail silently #9393

agr opened this issue Feb 18, 2023 · 2 comments

Comments

@agr
Copy link
Contributor

agr commented Feb 18, 2023

Impact

Other

Describe the bug

When large package is uploaded through the upload page it silently fails. There are errors in JS console in browser dev tools, but the page itself gives no feedback.

Repro Steps

  1. Author a package 300 MB in size
  2. Go to https://www.nuget.org/packages/manage/upload
  3. Try uploading it

Expected Behavior

An error is shown indicating that the package is too large.

Screenshots

image

Additional Context and logs

No response

@agr agr added the Type:Bug label Feb 18, 2023
@agr
Copy link
Contributor Author

agr commented Feb 18, 2023

Response code had changed? It seems there is code to handle the case, but it's checking for a different one:

// IIS returns 404.13 (NotFound) when maxAllowedContentLength limit is exceeded.
if (fullResponse === "Not Found") {
displayErrors(["The package file exceeds the size limit. Please try again."]);
}

@agr
Copy link
Contributor Author

agr commented Feb 18, 2023

Also, while messaging is consistent between several locations:

<value>The package file exceeds the size limit. Please try again.</value>

displayErrors(["The package file exceeds the size limit. Please try again."]);

<value>The package file exceeds the size limit. Please try again.</value>

That "Please try again" part is weird. Simply trying again will not help with package size exceeding limits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants