Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passProps type parameter to be used with Layout in ShowModalCommand #60

Open
dyerw opened this issue Mar 23, 2021 · 0 comments
Open

Comments

@dyerw
Copy link

dyerw commented Mar 23, 2021

The PushCommand show here allows the parameter P to specify the passProps type but it's not parameterized similarly in ShowModalCommand. I would like to validate my props when using the ShowModalCommand and I believe it just needs to be updated to a similar type. Thanks!

interface PushCommand {
    <P = {}>(layout: Layout<P>): Promise<any>;
    (name: string): Promise<any>;
    <P = {}>(name: string, passProps?: P): Promise<any>;
    <P = {}>(name: string, passProps?: P, options?: Options): Promise<any>;
}
interface ShowModalCommand {
    (layout: Layout): Promise<any>;
    <P = {}>(name: string, passProps?: P, options?: Options): Promise<any>;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant