Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listener name in error context is vague for nested classes #292

Open
haykam821 opened this issue Jun 10, 2024 · 0 comments
Open

Listener name in error context is vague for nested classes #292

haykam821 opened this issue Jun 10, 2024 · 0 comments

Comments

@haykam821
Copy link
Contributor

haykam821 commented Jun 10, 2024

For example, the GameActivityEvents.Tick method would be reported as Tick. Note that Plasmid itself doesn't contain any conflicting names when lacking the context of the outer class, but custom events could pose a risk.

var listenerName = event.getListenerType().getSimpleName();
Plasmid.LOGGER.warn("An unexpected exception occurred while invoking {}", listenerName, throwable);
space.getLifecycle().onError(space, throwable, "Invoking " + listenerName);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant