-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception thrown during custom counter creation will break other counters #102
Comments
A longer log that happened during my own testing
Here PP counter did not show up beacuse my mod threw an uncaught exception during initialization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
As the title, when Counter+ broadcasts a level start event to all the custom counters, if there is an uncought exception, it will cause this broadcast function to terminate. As a result all the counters that would load after this bugged counter will not reveive the event. Then they won't load.
Attach or Link Files
This comment in the issue of my custom counter shows the log when my custom counter threw an uncought exception.
Maybe add a try block into the
CounterEventBroadcaster.Initialize
foreach loop? So a bugged counter won't affect others.Additional context
This problem was found when fixing my own custom counter. lol
The text was updated successfully, but these errors were encountered: