-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions about sourceDescriptions
references and sructure
#184
Comments
I see why you are asking that. In this case when you import a workflow tooling would assume all workflows from all sources are "inlined" so workflow IDs are unique. There isn't any benefit or need to use .workflows. Each workflow document has one or more workflows in its workflows[] section and each has a unique id. When use sourceDescriptions. you're already specifying the workflow import so having workflows. or not wouldn't make any difference. I guess one could argue about "correctness" but me personally I don't see why we need to specify another layer when we know the id we are specifying is unique. Frankly we could probably avoid even using sourceDescriptions. but that makes it more readable.. so someone looking at the main source can see that a given workflow ID resides in a given imported source description. |
[Following up here from slack convo]: I think there are two options:
Either way, this probably needs to be cleaned up. Thanks for raising. |
From Dmytro:
Entry Workflow Document context is not available within a workflow accessed via the |
Hi Everyone,
I have a few questions about
sourceDescriptions
with the typeworkflowsSpec
.It appears that the intention is to reuse workflows from other files or sources.
I’m a bit puzzled by the way workflows are referenced throughout the document.
The commonly described example is
$sourceDescriptions.<name>.workflowId
, which creates some confusion with the suggested structure.In the suggested structure, the workflow seems to have an extra level of workflows:
So I’m wondering if this is a mistake and if we’re missing an extra
workflows
level in this reference$sourceDescriptions.<name>.workflows.<workflowId>
,or if it was done by design and all that should be available from the
sourceDescriptions
of typeworkflowsSpec
is just the list of workflows and nothing else. It this case more questions about usage ofsourceDescriptions
inside that file arise.Looking forward to your reply,
Thank you.
The text was updated successfully, but these errors were encountered: