Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch RFC 7231 to RFC 9110 #242

Open
philsturgeon opened this issue Aug 27, 2024 · 0 comments
Open

Switch RFC 7231 to RFC 9110 #242

philsturgeon opened this issue Aug 27, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation house-keeping House keeping items

Comments

@philsturgeon
Copy link

philsturgeon commented Aug 27, 2024

Similar to #241, RFC 7231 has been obsoleted by RFC 9110 & 9112.

The requestBody is fully supported in HTTP methods where the HTTP 1.1 specification [RFC7231] Section 4.3.1 has explicitly defined semantics for request bodies.

RFC 9110 refers to a HTTP request body as "content" instead of "payload" or "payload body", and mentions in the equivilent method semantics sections:

https://www.rfc-editor.org/rfc/rfc9110#section-9.3.1-6

Although request message framing is independent of the method used, content received in a GET request has no generally defined semantics, cannot alter the meaning or target of the request, and might lead some implementations to reject the request and close the connection because of its potential as a request smuggling attack (Section 11.2 of [HTTP/1.1]). A client SHOULD NOT generate content in a GET request unless it is made directly to an origin server that has previously indicated, in or out of band, that such a request has a purpose and will be adequately supported. An origin server SHOULD NOT rely on private agreements to receive content, since participants in HTTP communication are often unaware of intermediaries along the request chain.

That's still a "its weird probably dont do it" but its a bit more clearly specified.

I'd make a PR but im honestly not sure what's the best wording to change it to.

@philsturgeon philsturgeon changed the title Switch RFC 7231 to RFC 9110/9112 Switch RFC 7231 to RFC 9110 Aug 27, 2024
@frankkilcommins frankkilcommins added house-keeping House keeping items documentation Improvements or additions to documentation labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation house-keeping House keeping items
Projects
None yet
Development

No branches or pull requests

2 participants