-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate automation of closing issues that are labeled as "enhancement" but have not gained sufficient community interest #3430
Comments
What do you think of that? flowchart TD
openIssue["author open"]
labelIssue["a triager labels it as feature request"]
addMessage["explanatory message the author needs to gather support by people upvoting the issue"]
startCounter["counter for community support starts"]
isSupportGathered{"has the community support been achieved?"}
closeIssue["issue gets closed"]
prMerge["merge associated PR"]
addMessageForSchedule["worklow adds a message to prompt scheduling"]
addMilestone["triager adds a milestone, removes feature request, and adds enhancement"]
openIssue -- "triage" --> labelIssue
labelIssue -- "worklow posts a message" --> addMessage
addMessage -- "start the counter" --> startCounter
startCounter -- "counter runs out" --> isSupportGathered
isSupportGathered -- "no" --> closeIssue
isSupportGathered -- "yes" --> addMessageForSchedule
addMessageForSchedule ----> addMilestone
addMilestone ---> prMerge
prMerge -- "pr closes issue" --->closeIssue
The "community support" could be defined as:
|
I'd like to see some stats on how our currently-open and recently-closed feature requests score by the proposed heuristics. |
Couple of notes from the meeting:
(effectively we should eliminate the "yes" branch of the diagram here) |
@lornajane what kind of stats are you looking for? How long have issues been open on average? the upvotes? something else? |
I'd like to see some proposed criteria, and which existing issues would be affected by the automation |
I built a little script on my end to try and get some example.
Here is what the script returns
What do you think? Of course we could dig deeper, export all issues as CSV, an try to cluster them in excel or so. |
Instead of closing these "dead" feature request issues, may I suggest they be moved to Github Discussions? Then if there is enough traction on the discussion, a new issue/PR can be created for it. |
I dislike discussions because they just sit there forever, and the UX once they get complicated is horribly confusing... but other folks seem to like them so ¯\(ツ)/¯ I do think that if we are using discussions (and again, I'd really rather not but I'm pretty sure I lost that argument long ago), then putting big feature requests there is better. So I would support a policy of moving active big feature request issues to discussions. But for the more-or-less dead backlog... To me, it's more valuable to outright reject things if we're not doing them. Or to consolidate them under Moonwalk if they could find a home there. It's precisely the "things just sit open forever" that we got multiple complaints about near the end of last year. I think people want to know what's active and has a chance of happening. Creating 100 or so new discussions around ideas that never gained real traction feels like the opposite of that, to me. Let's bring some clarity and say "no" to things. If they're really that needed, someone will open it again and we can consider it in the context of 2024 and not 2017 or whatever. |
I think I'm in agreement with everyone here, on one thing or another! I don't like the idea of automatically closing issues, it is a very blunt instrument. That said, with 500 open issues, a tiny percentage of which can be actioned for OpenAPI 3.x, we do need to identify the ones that need our attention and which cannot proceed. It feels honest to me to close those that we are certain are not in the picture. There seems to be general agreement that we have things merged already that would merit a 3.2 - but anything that feels like more than a minor change should be redirected to 4.0 at this point. Some should become discussions for Moonwalk - there are things we can implement there that weren't possible or even just didn't have enough support to get into 3.x. Discussions: I can kind of see how they might be useful for questions rather than todo items, but I'm not sure how much engagement/activity we have there, or whether it's useful to spread things around without having clear guidelines of what goes where (apparently we can move things from one place to another). If we do want to use discussions, let's propose what we use them for and how they're managed first. |
@lornajane I agree, let's keep going with the manual closing (and thanks for your work there!) |
@karenetheridge I filed #3518 to define (among other things) criteria for closing vs migrating issues to discussions |
The text was updated successfully, but these errors were encountered: