[14.0][IMP] l10n_it_delivery_note: refactor delivery note creation by extracting value preparation into a separate method to allow inheriting #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MarcoCalcagni, @renda-dev, @aleuffre, |
GSLabIt
force-pushed
the
14.0-imp-l10n_it_delivery_note-prefer_prepare_delivery_note
branch
from
ddb1ac5 to
c8ff07b
Compare
GSLabIt
changed the title
GSLabIt
changed the title
|
L'unica cosa, il messaggio di commit deve essere max 80 caratteri |
GSLabIt
force-pushed
the
14.0-imp-l10n_it_delivery_note-prefer_prepare_delivery_note
branch
from
c8ff07b to
ff161c1
Compare
GSLabIt
force-pushed
the
14.0-imp-l10n_it_delivery_note-prefer_prepare_delivery_note
branch
from
ff161c1 to
9c104d7
Compare
2 tasks
2 tasks
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at e539ac8. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
riorganizzare la creazione del ddt estraendo la preparazione dei valori in un metodo separato per consentire di ereditare la funzione e aggiungere eventuali altri campi i.e. le note che potrebbero arrivare dal picking out