Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort version to be increased #553

Closed
KKamaa opened this issue Feb 6, 2023 · 2 comments
Closed

isort version to be increased #553

KKamaa opened this issue Feb 6, 2023 · 2 comments
Labels

Comments

@KKamaa
Copy link

KKamaa commented Feb 6, 2023

Module

Current version of maintertools

Describe the bug

Hey guys I saw that we havent update maintainer-tools isort version which leads to the error described here

To Reproduce

Current Version: just take OCA branch 16.0 and try using pre-commit on it.

Steps to reproduce the behavior:

  1. Get an OCA branch version 16.0
  2. using the maintainer-tools try running pre-commit run -a
  3. error pops

Expected behavior
pre-commit run needs to run without errors so the soln is to update the .pre-commit-config.yaml isort to new version e.g > 5.12.0

Additional context
So its an isort upgrade issue, latest isort will fix the error

@KKamaa KKamaa added the bug label Feb 6, 2023
@pedrobaeza
Copy link
Member

This was tackled in OCA/oca-addons-repo-template#184.

@pedrobaeza
Copy link
Member

Do pipx run copier -f update for upgrading the repo to latest copier template and do a PR fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants