Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 10, 11, 12 #103

Closed
4 tasks
sbidoul opened this issue Dec 31, 2021 · 5 comments · Fixed by #132
Closed
4 tasks

Add support for 10, 11, 12 #103

sbidoul opened this issue Dec 31, 2021 · 5 comments · Fixed by #132
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sbidoul
Copy link
Member

sbidoul commented Dec 31, 2021

This is necessary if we want to be able to unplug travis.

TODO

  • extract the flake8 config from MQT
  • extract the pylint config from MQT
  • create a pre-commit config that uses flake8 and pylint with the above configs
  • create a GitHub workflow for tests (the template we have right now should be ok and work for 10, 11, 12 too)
@sbidoul
Copy link
Member Author

sbidoul commented Jan 27, 2022

I think this task is the last one before we can stop Travis and switch all repos to GitHub actions.

If anyone wants to help with it, this is most welcome. I'm happy to provide any guidance that would be necessary.

@carmenbianca
Copy link
Member

@sbidoul Hi! I'm taking a look at adding support for 12.0. I have no experience with 10.0 and 11.0, but I'll see if I can do those as well.

@sbidoul
Copy link
Member Author

sbidoul commented Feb 23, 2022

@carmenbianca that's great! I have started something in #117. Feel free to pick it up from there. I will not have much time to work on this myself before mid-end march, but let me know if you have any question or doubt on how to move forward.

@carmenbianca
Copy link
Member

@sbidoul I did a review and some suggestions. I'm a little lost on what specifically is missing/todo. OCA/l10n-italy#2658 demonstrates that #117 mostly works. The test failures seem to be true positives for the maintainers to address.

@sbidoul
Copy link
Member Author

sbidoul commented Feb 23, 2022

mostly works

"mostly" is the keyword :)

This needs to be made to work and tested in a few representative repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants