Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not needed POT updates #227

Closed
pedrobaeza opened this issue Dec 9, 2022 · 5 comments
Closed

Not needed POT updates #227

pedrobaeza opened this issue Dec 9, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@pedrobaeza
Copy link
Member

Look at this POT update commit:

OCA/l10n-spain@6a2ab18

It's not changing anything valuable, but it requires another CI to be launched, provoking commit noise and delay on the merges.

Can this be avoided?

@pedrobaeza pedrobaeza added the bug Something isn't working label Dec 9, 2022
@sbidoul
Copy link
Member

sbidoul commented Dec 9, 2022

This is not the right project for this issue. It might be click-odoo-contrib or, more likely, Odoo itself, or the library it uses to generate pot files.

@pedrobaeza
Copy link
Member Author

I don't know who generates it, but do you agree it's a problem?

@sbidoul
Copy link
Member

sbidoul commented Dec 9, 2022

Not sure. Where do these two lines it is removing come from?

@pedrobaeza
Copy link
Member Author

I launched the ocabot command for merging in OCA/l10n-spain#2574, and on the merge branch, such commit was added. I suppose that the bot launches POT+PO update in some moment.

@sbidoul
Copy link
Member

sbidoul commented Dec 28, 2022

Was due to en.po being present. So closing.

@sbidoul sbidoul closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants