Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore W7930 for XML files not to be handled by manifest #102

Closed
eLBati opened this issue Jan 10, 2017 · 8 comments
Closed

ignore W7930 for XML files not to be handled by manifest #102

eLBati opened this issue Jan 10, 2017 · 8 comments

Comments

@eLBati
Copy link
Member

eLBati commented Jan 10, 2017

See
https://travis-ci.org/OCA/l10n-italy/jobs/190682978
in particular
l10n_it_fatturapa_out/tests/data/IT06363391001_00001.xml:1: [W7930(file-not-used), ] not used from manifest

That XML file is used by automatic tests, to check the result of invoice export, so it must not be used by manifest.
So, pylint-odoo should not raise the error.

@pedrobaeza
Copy link
Member

It's only a warning, so no special problem. Anyway, there's some excluded folder that you can use for holding this kind of files without even warning. I don't remember now which. @moylop260, do you?

@eLBati
Copy link
Member Author

eLBati commented Jan 10, 2017

But OCA/l10n-italy#265 is red because of lint checks
Isn't it because of W7930?
Thanks

@pedrobaeza
Copy link
Member

pedrobaeza commented Jan 10, 2017

No, it's red because of:

l10n_it_fatturapa/bindings/_ds.py:10: [W7935(missing-import-error), ] External dependency "pyxb" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/_ds.py:11: [W7935(missing-import-error), ] External dependency "pyxb.binding" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/_ds.py:12: [W7935(missing-import-error), ] External dependency "pyxb.binding.saxer" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/_ds.py:14: [W7935(missing-import-error), ] External dependency "pyxb.utils.utility" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/_ds.py:15: [W7935(missing-import-error), ] External dependency "pyxb.utils.domutils" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/_ds.py:16: [W7935(missing-import-error), ] External dependency "pyxb.utils.six" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/_ds.py:19: [W7935(missing-import-error), ] External dependency "pyxb.binding.datatypes" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies

************* Module l10n_it_fatturapa.bindings.fatturapa_v_1_2

l10n_it_fatturapa/bindings/fatturapa_v_1_2.py:10: [W7935(missing-import-error), ] External dependency "pyxb" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/fatturapa_v_1_2.py:11: [W7935(missing-import-error), ] External dependency "pyxb.binding" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/fatturapa_v_1_2.py:12: [W7935(missing-import-error), ] External dependency "pyxb.binding.saxer" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/fatturapa_v_1_2.py:14: [W7935(missing-import-error), ] External dependency "pyxb.utils.utility" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/fatturapa_v_1_2.py:15: [W7935(missing-import-error), ] External dependency "pyxb.utils.domutils" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/fatturapa_v_1_2.py:16: [W7935(missing-import-error), ] External dependency "pyxb.utils.six" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/fatturapa_v_1_2.py:19: [W7935(missing-import-error), ] External dependency "pyxb.binding.datatypes" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa/bindings/fatturapa_v_1_2.py:20: [W0403(relative-import), ] Relative import '_ds', should be 'l10n_it_fatturapa.bindings._ds'

************* Module l10n_it_fatturapa_out.wizard.wizard_export_fatturapa

l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py:7: [W7935(missing-import-error), ] External dependency "unidecode" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py:9: [W7935(missing-import-error), ] External dependency "pyxb.exceptions_" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py:9: [W7936(missing-manifest-dependency), ] Missing external dependency "pyxb.exceptions_" from manifest. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies

@eLBati
Copy link
Member Author

eLBati commented Jan 10, 2017

@pedrobaeza ok, thanks. PR is green now.

Let's just see if @moylop260 knows the excluded folder

@moylop260
Copy link
Collaborator

I tried add this case in the README of this project
I'm sorry if It isn't clear.
Any suggestion is welcome.

https://github.com/OCA/pylint-odoo#usage
If you have external files you can add them in examples folder to skip.

@moylop260
Copy link
Collaborator

moylop260 commented Jan 10, 2017

Maybe we should consider tests folder too as folder to skip this check.

@pedrobaeza
Copy link
Member

Yes, tests is a good candidate also.

@moylop260
Copy link
Collaborator

Tests folders skipped from #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants