Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMA reason #405

Open
5 tasks
jbaudoux opened this issue Jul 4, 2024 · 6 comments · May be fixed by #409
Open
5 tasks

RMA reason #405

jbaudoux opened this issue Jul 4, 2024 · 6 comments · May be fixed by #409

Comments

@jbaudoux
Copy link

jbaudoux commented Jul 4, 2024

Add rma reason

To improve quality, it is good to understand why an RMA has been created.

For this I'd like to have a required RMA reason defined on the RMA. This would be also available and required on the SO wizard on each line (or globally)

Make a rma_reason module that depends on rma

  • Define a model rma.reason with name, action, company + unique(name, company). Security: read for rma user, crud for rma manager
  • Allow to configure on the company if the reason is mandatory and check accordingly if the field is filled in _ensure_required_fields
  • Add a m2o field to reason on rma model and display on form view after Requested operation

Make a rma_sale_reason module that depends on rma_sale and rma_reason

  • In the SO create rma wizard, add on each product line a field (optional or required based on company setting) to set the reason for the lines.
  • In the SO create rma wizard, add before the list of products an optional field to set the default reason for all the lines. Make on all product lines the reason computed stored based on that default reason
@chienandalu
Copy link
Member

Well, that's what the RMA operations are for. The module pre-creates three of them, but you can change them or add as many as you want to.

And customers in the sale portal can select them and even add notes per return line

@jbaudoux
Copy link
Author

jbaudoux commented Jul 4, 2024

In fact, it serves two different purpose.
I use the operation to dictate what process should apply (return, refund, replace...) and which will create the right transfer (incoming, delivery or both, credit note...). In my use cases, it is the after-sales service that choose the right operation to apply.
The reason would explain the cause of this RMA like: wrong item delivered, customer don't want the product anymore, product has a defect, wrong product description... In the same spirit than https://github.com/OCA/sale-workflow/tree/16.0/sale_cancel_reason

@chienandalu
Copy link
Member

I understand. There's a similar optional feature (group_rma_manual_finalization) for manual finalization reasons. Maybe you could propose a similar approach.

@jbaudoux
Copy link
Author

jbaudoux commented Jul 4, 2024

I understand. There's a similar optional feature (group_rma_manual_finalization) for manual finalization reasons. Maybe you could propose a similar approach.

Can you provide the link to that module, I can't find it ?

@chienandalu
Copy link
Member

It's in the rma module itself. Follow the code for this option:

group_rma_manual_finalization = fields.Boolean(
string="Finish RMA manually choosing a reason",
help="Allow to finish an RMA without returning back a product or refunding",
implied_group="rma.group_rma_manual_finalization",
)

@jbaudoux
Copy link
Author

I updated the issue with the proposed solution specifications

@rousseldenis rousseldenis linked a pull request Jul 17, 2024 that will close this issue
@sbejaoui sbejaoui linked a pull request Jul 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants