Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] rma_sale: Display the allowed quantity to return in the RMA wizard #407

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP] rma_sale: Display the allowed quantity to return in the RMA wizard #407

wants to merge 1 commit into from

Conversation

sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Jul 12, 2024 •
edited
Loading

fixes: #406

  • Display the allowed quantity to return
  • Simplify data encoding by adding a button to select/deselect all lines
  • Ensure that the quantity to return is always less than or equal to the allowed quantity

image

@OCA-git-bot
Copy link
Contributor

Hi @chienandalu,
some modules you are maintaining are being modified, check this out!

@rousseldenis rousseldenis added this to the 16.0 milestone Jul 12, 2024
@rousseldenis rousseldenis linked an issue Jul 12, 2024 that may be closed by this pull request
RMA SO wizard quantity default to 0 and show max #406
Open
@sbejaoui sbejaoui force-pushed the 16.0-rma_sale-sbj branch 2 times, most recently from 9d8d8b4 to eb0bede Compare July 12, 2024 15:04
@pedrobaeza pedrobaeza changed the title [IMP] rma_sale: Display the allowed quantity to return in the RMA wizard [16.0][IMP] rma_sale: Display the allowed quantity to return in the RMA wizard Jul 12, 2024
@sbejaoui sbejaoui force-pushed the 16.0-rma_sale-sbj branch from eb0bede to 3d98a44 Compare July 15, 2024 10:31
lmignon
lmignon approved these changes Jul 15, 2024
View reviewed changes
Copy link

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review + functional tests)

@sbejaoui sbejaoui force-pushed the 16.0-rma_sale-sbj branch from 3d98a44 to c3aba07 Compare July 15, 2024 19:28
jbaudoux
jbaudoux reviewed Aug 2, 2024
View reviewed changes
Copy link

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you perform the same in the stock picking return ?
You can also create RMAs from there

jbaudoux
jbaudoux requested changes Aug 2, 2024
View reviewed changes
Copy link

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change the product in the wizard line, the allowed quantity is not recomputed.
As the check on the wizard validation is on the allowed quantity of the lines, it is not ensuring properly the constraint (as you may have changed the product).

If you add a line in the wizard and select a product, the allowed quantity is not recomputed.

@sbejaoui
[IMP] rma_sale: Display the allowed quantity to return in the RMA wizard
2813e81 
- Display the allowed quantity to return
- Simplify data encoding by adding a button to select/deselect all lines
- Ensure that the quantity to return is always less than or equal to the allowed quantity
jbaudoux
jbaudoux approved these changes Nov 13, 2024
View reviewed changes
Copy link

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the improvement on the SO rma wizard.
My previous remark on changing prepopulated quantity fields to computed fields would require a refactor that is better suited in another PR as this issue about wizard line removal and addition, or product change, is already there and not due to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaudoux jbaudoux jbaudoux approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
approved enhancement needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

RMA SO wizard quantity default to 0 and show max
5 participants
@sbejaoui @OCA-git-bot @lmignon @jbaudoux @rousseldenis