[16.0][FIX] rma: group rma receptions #423
Conversation
|
Hi @chienandalu, @pedrobaeza, |
sbejaoui
force-pushed
the
16.0-rma_group_reception-sbj
branch
from
c9815df to
3ac056c
Compare
sbejaoui
changed the title
sbejaoui
force-pushed
the
16.0-rma_group_reception-sbj
branch
from
3ac056c to
e439f6a
Compare
| @@ -26,6 +26,9 @@ def _default_rma_mail_draft_template(self): | |||
| except ValueError: | |||
| return False | |||
|
|
|||
| rma_reception_grouping = fields.Boolean( | |||
| string="Group RMA receptions", default=False | |||
There was a problem hiding this comment.
Maybe a help string should be great
|
Seeing the original problem, this fix shouldn't be an option, but act always this way, don't you think? |
| @@ -732,6 +732,10 @@ def action_confirm(self): | |||
| self = self.filtered(lambda rma: rma.state == "draft") | |||
| if not self: | |||
| return | |||
| if self.env.company.rma_reception_grouping: | |||
There was a problem hiding this comment.
| if self.env.company.rma_reception_grouping: | |
| if not self.procurement_group_id: |
There was a problem hiding this comment.
Indeed, it should be the default behavior and then there is no need for an option. I don't see anything setting a value in procurement_group_id except create_receipt that you fixed here https://github.com/OCA/rma/pull/421/files#diff-3d6f82bd3aa96a98f1dd5cd6389cb926247243353dda39dc5bbf9924b53c98cbR715 and create_replace here https://github.com/OCA/rma/blob/16.0/rma/models/rma.py#L1212
So this fix should be obsolete as what Pedro is suggesting is already like that. Or there is something else setting a value here that needs to be overridden ?
There was a problem hiding this comment.
You may set this value manually if you are interested to put a specific group, so let's keep this option open.
fixes: #422